search

NCAR / esmlab-regrid

ESMLab Regridding Utilities. ⚠️⚠️ ESMLab-regrid functionality has been moved into <https://github.com/NCAR/geocat-comp>. ⚠️⚠️
https://esmlab-regrid.readthedocs.io
Apache License 2.0
4 stars 5 forks source link

Cleaned up core.py to pass circleci linting test #10

Closed mnlevy1981 closed 4 years ago

mnlevy1981 commented 4 years ago

flake8 was balking at an extra newline in the code, and after fixing that black wanted to reformat a few calls with multiple arguments.

mnlevy1981 commented 4 years ago

On the plus side, the liniting test is passing now! (I think there must be an upstream package change somewhere -- #9 passed the python tests but that was 4 months ago)

andersy005 commented 4 years ago

There was a new release of xesmf a few weeks ago, and I suspect some of the issues to be coming from xesmf (not 💯sure) . Looking at the CI logs, the issue seems to be related to NumPy's assertion though.

mnlevy1981 commented 4 years ago

@andersy005 it was indeed xesmf -- d602b1f is a band-aid (rolling back to the older xesmf), but figuring out the new API to apply_weights() would be a better path forward in my opinion