daylight_fao56 - Githubissues

NCAR / geocat-applications

GeoCAT Applications is a community resource inspired by the NCL Applications page.

https://ncar.github.io/geocat-applications/

Apache License 2.0

5 stars 5 forks source link

daylight_fao56 #115

Closed cyschneck closed 1 month ago

cyschneck commented 2 months ago

PR Summary

Add Meteorology max_daylight geocat function to resolve NCL daylight_fao56 function

Covers:

daylight_fao56

Related Tickets & Documents

Closes #104

PR Checklist

General

[x] PR includes a summary of changes
[x] Link relevant issues, make one if none exist
If adding a new page, select which type:
- [x] NCL Entry
- [x] Receipt

review-notebook-app[bot] commented 2 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

github-actions[bot] commented 2 months ago

Meowdy! See your PR preview: 🔍 Git commit SHA: f4ab11e935f0db980837e4ae6e68fc8f0455a5d2 ✅ Deployment Preview URL: https://NCAR.github.io/geocat-applications/_preview/115

cyschneck commented 1 month ago

Combined dewtemp and daylight functions into a single NCL entry, which will eventually include additional meteorology functions

jukent commented 1 month ago

@cyschneck I won't be able to look at this until Monday.

kafitzgerald commented 1 month ago

The pre-commit failure here looks like it's the same as on https://github.com/NCAR/geocat-examples/pull/618.

I ended up just commenting docformatter out for now in the pre-commit config and logging an issue to add it back once the new release is out to address this there.

cyschneck commented 1 month ago

The pre-commit failure here looks like it's the same as on https://github.com/NCAR/geocat-examples/pull/618.

I ended up just commenting docformatter out for now in the pre-commit config and logging an issue to add it back once the new release is out to address this there.

Will do