NCAR / geocat-applications

GeoCAT Applications is a community resource inspired by the NCL Applications page.
https://ncar.github.io/geocat-applications/
Apache License 2.0
4 stars 5 forks source link

Python datetime and days_in_month #44

Closed anissa111 closed 4 weeks ago

anissa111 commented 1 month ago

PR Summary

Related Tickets & Documents

Part of #15 Closes #45

PR Checklist

General

Spawned issues

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

github-actions[bot] commented 1 month ago

Meowdy! See your PR preview: 🔍 Git commit SHA: 144ddd7a5197c656f0b0baddf49064c67109d0a9 ✅ Deployment Preview URL: https://NCAR.github.io/geocat-applications/_preview/44

cyschneck commented 1 month ago

Looks great! More of a general question, should the Date and Time header be a link? image

anissa111 commented 1 month ago

Looks great! More of a general question, should the Date and Time header be a link? image

Good question! That comes from a design decision we made way early on, where each "card" would have a landing page with more detailed previews of all the notebooks in the folder. Right now, though, that "landing page" just has a toc on it.

I think the original decision might make more sense once we have more content and once we decide what those "landing pages" should look like, but should we skip having them for now until they make more sense? @jukent @kafitzgerald

jukent commented 1 month ago

Yes I believe the idea is to have gallery cards for each individual example under each category. I have no problem with removing it for now though.