Closed anissa111 closed 4 weeks ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Meowdy! See your PR preview: 🔍 Git commit SHA: 144ddd7a5197c656f0b0baddf49064c67109d0a9 ✅ Deployment Preview URL: https://NCAR.github.io/geocat-applications/_preview/44
Looks great! More of a general question, should the Date and Time
header be a link?
Looks great! More of a general question, should the
Date and Time
header be a link?
Good question! That comes from a design decision we made way early on, where each "card" would have a landing page with more detailed previews of all the notebooks in the folder. Right now, though, that "landing page" just has a toc on it.
I think the original decision might make more sense once we have more content and once we decide what those "landing pages" should look like, but should we skip having them for now until they make more sense? @jukent @kafitzgerald
Yes I believe the idea is to have gallery cards for each individual example under each category. I have no problem with removing it for now though.
PR Summary
days_in_month
in ncl/ncl_entries/days_in_month.ipynbdays_in_month
receipt to ncl/receipts/days_in_month.ipynbdays_in_month
Related Tickets & Documents
Part of #15 Closes #45
PR Checklist
General
Spawned issues
48