Humid Heat Metrics - Githubissues

NCAR / geocat-applications

GeoCAT Applications is a community resource inspired by the NCL Applications page.

https://ncar.github.io/geocat-applications/

Apache License 2.0

5 stars 5 forks source link

Humid Heat Metrics #66

Closed jukent closed 2 months ago

jukent commented 5 months ago

PR Summary

Human heat metrics applications notebook demonstrating different 4 methods of calculating wet bulb global temperature.

Related Tickets & Documents

Closes Comp #192

PR Checklist

General

[ ] PR includes a summary of changes
[ ] Link relevant issues, make one if none exist

review-notebook-app[bot] commented 5 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

github-actions[bot] commented 5 months ago

Meowdy! See your PR preview: 🔍 Git commit SHA: fd94e40e29e3b981ffdbc5d0ec985a5ef11ce741 ✅ Deployment Preview URL: https://NCAR.github.io/geocat-applications/_preview/66

jukent commented 4 months ago

This PR addresses 2 methods (ABM and Bernard)

anissa111 commented 3 months ago

Also (had a hard time including this on reviewNB, sorry), it looks like the docs are still having trouble with the equations.

Not sure if this is a formatting thing here or if we haven't set up the config file properly to handle latex formatting, though.

jukent commented 3 months ago

Also (had a hard time including this on reviewNB, sorry), it looks like the docs are still having trouble with the equations.

Oh I've seen this before with Pythia. We'll have to ensure Mathjax is in the config file. I feel like it was more finicky than should be (appearing correctly in local builds but not in the .md cells or something like that).

jukent commented 3 months ago

Math is working now. I cleared the output because we're making the notebooks execute on build soon.

anissa111 commented 3 months ago

Just dropping a note that this is waiting on #97

anissa111 commented 2 months ago

Looks like the preview action is having a bit of trouble. I'm going to look into it now and make an issue if this is a broader issue than this PR.

jukent commented 2 months ago

preview action is having a bit of trouble

Thanks @anissa111 for bringing this to my attention. I removed the loooong list of authors in references.bib.

anissa111 commented 2 months ago

preview action is having a bit of trouble

Thanks @anissa111 for bringing this to my attention. I removed the loooong list of authors in references.bib.

Wait, I don't think we have to do this, bibtex just wants us to use "and" instead of commas. I have it working locally with that change, I'll push it to save you the trouble of remaking it.

jukent commented 2 months ago

Okay no worries either way, it seems like enough authors that "et al" is appropriate.