search

NCAR / geocat-comp

GeoCAT-comp provides implementations of computational functions for operating on geosciences data. Many of these functions originated in NCL and were translated into Python.
https://geocat-comp.readthedocs.io
Apache License 2.0
129 stars 56 forks source link

[💡]: The running speed of delta_pressure #619

Open cccccoldrun opened 6 months ago

cccccoldrun commented 6 months ago

Describe the functionality you are requesting, linking any relevant usage or previous implementations in the python ecosystem or otherwise.

Hello developers, here I am again, after you guys fixed the delta_pressure bug, it seems that its speed of operation has dropped drastically. I have a 200200300 (time,lat,lon) array about the pressure, in NCL it can be calculated in about 1 minute, while in Python this seems to take a long time.

Is this a request for functionality that was previously in NCL?

Yes

Additional context

No response

kafitzgerald commented 6 months ago

Thanks for the the report!

Just to clarify, was this slow down from NCL to GeoCAT or GeoCAT (before the fix) to GeoCAT (after the fix) or both? Regardless, we can take a look, but this would be useful context if you have it.

cccccoldrun commented 6 months ago

Hello: After testing, the GeoCAT (after the fix) is slower than NCL, the results of the GeoCAT (before the fix) were not tested, and my test is as follows: NCL code and result: 屏幕截图 2024-05-17 094003 屏幕截图 2024-05-17 093833 NCL finished this test using 3s.

Python code and result: 屏幕截图 2024-05-17 105719 while Python spends 524s, if the pressure level is incremental， it will spend more time