search

NCAR / geocat-comp

GeoCAT-comp provides implementations of computational functions for operating on geosciences data. Many of these functions originated in NCL and were translated into Python.
https://geocat-comp.readthedocs.io
Apache License 2.0
129 stars 56 forks source link

[GA-1538] Upstream CI is failing #620

Open kafitzgerald opened 6 months ago

kafitzgerald commented 6 months ago

Please describe your issue here

Upstream CI is failing as of a couple of days ago (first failure here), because of the use of the now deprecated np.product in eofs.

It looks like there's an open PR to address this, but it's been sitting for a bit.

anissa111 commented 6 months ago

Also want to note here that even though our upstream CI is picking this up, we have numpy<2.0 pinned, so this won't affect our regular CI or up-to-date releases.

kafitzgerald commented 1 month ago

It looks like that PR over on eofs still hasn't been merged. I wonder if we should look into using something like xeofs or generally doing something different for EOFs.

It might also be worth thinking about doing more of this via applications and deprecating the functions here. Given that deprecations (should) take some time and this seems to be the main (or maybe only) reason for the numpy version pin, it might not be a bad idea to have that discussion sooner rather than later.