search

NCAR / geocat-comp

GeoCAT-comp provides implementations of computational functions for operating on geosciences data. Many of these functions originated in NCL and were translated into Python.
https://geocat-comp.readthedocs.io
Apache License 2.0
125 stars 56 forks source link

Q: geocat.comp.ndpolyfit() moved upstream to Xarray. Should ndpolyfit be removed from geocat.comp? #63

Open pilotchute opened 4 years ago

pilotchute commented 4 years ago

Xarray implemented polyfit and polyval on: https://github.com/pydata/xarray/pull/3733 Should the duplicate functionality in geocat.comp.ndpolyfit be preserved?

To start the discussions: Pros: maintains backward compatibility for all projects.

Cons: functionally with current polyfit in pydata.xarray is duplicated, and pydata.polyfit should become the reference implementation now that it has been moved upstream.

Potential resolution: refactor geocat.comp.ndpolyfit as an alias to pydata.xarrray.polyfit. this preserves compatibility with code that calls comp.ndpolyfit, while allowing xarray.polyfit to be the implementation.

pilotchute commented 3 years ago
anissa111 commented 2 years ago

@pilotchute any updated thoughts on this?