NCAR / geocat-examples

GeoCAT-examples provides a gallery of visualization examples demonstrating how to reproduce plots from NCL Applications scripts with packages in Python. It also includes some longer form examples demonstrating how to use functionality from various GeoCAT packages.
https://geocat-examples.readthedocs.io
Apache License 2.0
66 stars 42 forks source link

Temporarily remove incorrect NCL_vector_5.py example #618

Closed kafitzgerald closed 1 month ago

kafitzgerald commented 1 month ago

Removes the (incorrect) NCL_vector_5.py example until we have a working curly vector implementation.

Closes #616 Relates to #314

If we'd rather not remove this for now, we could also look into using quiver from Matplotlib like some of the other vector examples, but I don't think that's a great option for this particular example. The vector field is rather complex and I think it'd be difficult to represent with that plot type. A streamplot is another option, but that's really a different type of visualization.

kafitzgerald commented 1 month ago

This is failing pre-commit because of https://github.com/PyCQA/docformatter/issues/293

jukent commented 1 month ago

I'm in favor of removing it, as you showed here. Or adding some sort of annotation that the example is not displaying scientifically significant vector lengths. I wonder if there are people using this example as a template for other visualization needs (pretty sure they're captured in a different example).

kafitzgerald commented 1 month ago

I'm in favor of removing it, as you showed here. Or adding some sort of annotation that the example is not displaying scientifically significant vector lengths. I wonder if there are people using this example as a template for other visualization needs (pretty sure they're captured in a different example).

Yeah, we have other streamplot examples already so I think the best thing to do here is remove it while we address the issue.