Deprecation warning from Matplotlib coming from the Taylor diagram code

NCAR / geocat-viz

GeoCAT-viz contains tools to help plot geoscience data, including convenience and plotting functions that are used to facilitate plotting geosciences data with Matplotlib, Cartopy, and other visualization packages.

https://geocat-viz.readthedocs.io

Other

48 stars 19 forks source link

Deprecation warning from Matplotlib coming from the Taylor diagram code #244

Closed kafitzgerald closed 1 week ago

kafitzgerald commented 1 month ago

We're seeing the following warning in testing:

tests/test_taylor.py::test_add_corr_grid C:\Miniconda\envs\geocat_viz_build\lib\site-packages\geocat\viz\taylor.py:423: MatplotlibDeprecationWarning: Passing apply_theta_transforms=True (the default) is deprecated since Matplotlib 3.9. Support for this will be removed in Matplotlib in 3.11. To prevent this warning, set apply_theta_transforms=False, and make sure to shift theta values before being passed to this transform.

kafitzgerald commented 1 week ago

I did a bit of testing locally and this (apply_theta_transforms=False) doesn't seem to change the results of our tests.

The argument is also not available until Matplotlib 3.9 and later.

I'm inclined to just leave this as is for now with the warning rather than code around Matplotlib versions.

We can revisit if problems arise or others feel strongly about this.