NCAR / icar

The Intermediate Complexity Atmospheric Research model (ICAR)
MIT License
72 stars 53 forks source link

Update ideal test to produce precipitation with an ideal hill #105

Closed gutmann closed 2 years ago

gutmann commented 2 years ago

TYPE: enhancement

KEYWORDS: ideal, test, helpers

SOURCE: Ethan Gutmann, NCAR

DESCRIPTION OF CHANGES: Modified the ideal test, simplifying it, making it a touch more pythonic, fixing a bug (t_is_potential was needed), adding an ideal hill to the topography so it will produce precipitation, extending the run from 6hrs to 24hrs.

ISSUE: n/a

TESTS CONDUCTED: ran the ideal test and confirmed that output files created had precipitation in them in a reasonable place.

NOTES: Plenty more things that can / should be added to the ideal test (or more ideal tests should be created).

Checklist