NCAR / icar

The Intermediate Complexity Atmospheric Research model (ICAR)
MIT License
72 stars 53 forks source link

Adding RRTMG radiation #106

Closed trudeeidhammer closed 2 years ago

trudeeidhammer commented 2 years ago

TYPE: New feature

KEYWORDS: Radiation, RRTMG

SOURCE: Trude Eidhammer, NCAR

DESCRIPTION OF CHANGES: We added the radiation code RRTMG. The RRTMG code base is from WRF version WRFV4.2.2. To run with RRTMG, use namelist option rad = 3.

ISSUE: Not related to any issues.

TESTS CONDUCTED:

NOTES: To use RRTMG, the directroy under icar_supporting_files/rrtmg_support must be downloaded and. rrtmg_support should be put in the directory where icar is run.

Checklist

Merging the PR depends on following checklist being completed. Add X between each of the square brackets if they are completed in the PR itself. If a bullet is not relevant to you, please comment on why below the bullet.

Screen Shot 2022-02-03 at 11 32 49 AM

Differences in 2m temperature between using the Simple Radiation and the RRTMG scheme. Also differences in 2m temperature from using different numbers of vertical layers

gutmann commented 2 years ago

Also, please note where it is possible to get the netcdf files you created for RRTMG, and add a description to the namelist files in the run directory noting that it is now possible to use rrtmg.

trudeeidhammer commented 2 years ago

Currently the netcdf files are located in the same directory as where I run ICAR. So I could copy all the files into the run directory in the source code (where the *.TBL) files also are located. But there are a lot of files, so perhaps we would like to create a new directory in the run directory.

On Thu, Jan 27, 2022 at 12:12 PM Ethan Gutmann @.***> wrote:

Also, please note where it is possible to get the netcdf files you created for RRTMG, and add a description to the namelist files in the run directory noting that it is now possible to use rrtmg.

— Reply to this email directly, view it on GitHub https://github.com/NCAR/icar/pull/106#issuecomment-1023554302, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD24I5MZUUK3PTZMU42MLIDUYGKITANCNFSM5M4GCK7Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

-- My working day may not be your working day. Please do not feel obliged to reply to this email outside of your normal working hours.

She/Her/Hers Dr. Trude Eidhammer Project Scientist II Research Applications Laboratory (RAL) National Center for Atmospheric Research (NCAR) P.O. Box 3000 Boulder, CO 80307-3000, USA

gutmann commented 2 years ago

How large are the netcdf files? I don't want to add them to git if they are more than a few MB... We should see if we can host them on an ftp site or the like (semi-permanently).

And yes, there are a lot of files, so let's put them in a sub-directory in the run directory (maybe just called rrtmg_support?) But if we aren't adding them to the git repo because they are "large" then lets create that sub-directory in the run directory, and within it, put a small text file telling users where they can download those files. Even better, it could be a shell script that downloads the files.

Then change the rrtmg code to read from netcdf files in a sub-directory (I think the file path is hard coded right?)

gutmann commented 2 years ago

Also, please edit the opening comment in this conversation to describe the pull request.

trudeeidhammer commented 2 years ago

The files are 2MB in total. And I will edit the opening comment

On Mon, Jan 31, 2022 at 11:45 AM Ethan Gutmann @.***> wrote:

Also, please edit the opening comment in this conversation to describe the pull request.

— Reply to this email directly, view it on GitHub https://github.com/NCAR/icar/pull/106#issuecomment-1026093859, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD24I5M55HQAB7QAN425ZOTUY3KELANCNFSM5M4GCK7Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

-- My working day may not be your working day. Please do not feel obliged to reply to this email outside of your normal working hours.

She/Her/Hers Dr. Trude Eidhammer Project Scientist II Research Applications Laboratory (RAL) National Center for Atmospheric Research (NCAR) P.O. Box 3000 Boulder, CO 80307-3000, USA

gutmann commented 2 years ago

Thanks 2MB isn't too bad, but I can see this getting out of hand in a few years. I just created a new repo for this purpose : https://github.com/NCAR/icar_supporting_files Can you please fork & clone that repo, add a directory with those files (gzipped) to it, then create a separate pull request to that repo to add the files?

If it is possible to add a tiny amount of metadata to those files (e.g. what are the dimensions, what is the meaning of each variable), please do that before creating the PR, as updating them at all will result in storing a new copy of each file.

This provides a place to store binary files, and we can write a small script to download them.

trudeeidhammer commented 2 years ago

I am trying to add some text based on the template, but I cannot figure out how I actually can edit that template

On Mon, Jan 31, 2022 at 3:25 PM Ethan Gutmann @.***> wrote:

Thanks 2MB isn't too bad, but I can see this getting out of hand in a few years. I just created a new repo for this purpose : https://github.com/NCAR/icar_supporting_files Can you please fork & clone that repo, add a directory with those files (gzipped) to it, then create a separate pull request to that repo to add the files?

If it is possible to add a tiny amount of metadata to those files (e.g. what are the dimensions, what is the meaning of each variable), please do that before creating the PR, as updating them at all will result in storing a new copy of each file.

This provides a place to store binary files, and we can write a small script to download them.

— Reply to this email directly, view it on GitHub https://github.com/NCAR/icar/pull/106#issuecomment-1026273655, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD24I5LD3G7OKOJRGKKWSUTUY4D4BANCNFSM5M4GCK7Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

-- My working day may not be your working day. Please do not feel obliged to reply to this email outside of your normal working hours.

She/Her/Hers Dr. Trude Eidhammer Project Scientist II Research Applications Laboratory (RAL) National Center for Atmospheric Research (NCAR) P.O. Box 3000 Boulder, CO 80307-3000, USA

trudeeidhammer commented 2 years ago

There are 222 separate files. The number of individual variable names are fewer (but the dimension in the files for the same variables sometimes changes). I wonder if it is easier and faster to write a document, describing the variable names instead of adding metadata.

[image: image.png]

On Tue, Feb 1, 2022 at 1:46 PM Trude Eidhammer @.***> wrote:

I am trying to add some text based on the template, but I cannot figure out how I actually can edit that template

On Mon, Jan 31, 2022 at 3:25 PM Ethan Gutmann @.***> wrote:

Thanks 2MB isn't too bad, but I can see this getting out of hand in a few years. I just created a new repo for this purpose : https://github.com/NCAR/icar_supporting_files Can you please fork & clone that repo, add a directory with those files (gzipped) to it, then create a separate pull request to that repo to add the files?

If it is possible to add a tiny amount of metadata to those files (e.g. what are the dimensions, what is the meaning of each variable), please do that before creating the PR, as updating them at all will result in storing a new copy of each file.

This provides a place to store binary files, and we can write a small script to download them.

— Reply to this email directly, view it on GitHub https://github.com/NCAR/icar/pull/106#issuecomment-1026273655, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD24I5LD3G7OKOJRGKKWSUTUY4D4BANCNFSM5M4GCK7Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

-- My working day may not be your working day. Please do not feel obliged to reply to this email outside of your normal working hours.

She/Her/Hers Dr. Trude Eidhammer Project Scientist II Research Applications Laboratory (RAL) National Center for Atmospheric Research (NCAR) P.O. Box 3000 Boulder, CO 80307-3000, USA

-- My working day may not be your working day. Please do not feel obliged to reply to this email outside of your normal working hours.

She/Her/Hers Dr. Trude Eidhammer Project Scientist II Research Applications Laboratory (RAL) National Center for Atmospheric Research (NCAR) P.O. Box 3000 Boulder, CO 80307-3000, USA

gutmann commented 2 years ago

I am trying to add some text based on the template, but I cannot figure out how I actually can edit that template

Click the "..." in the top right of that box, then select edit

trudeeidhammer commented 2 years ago

I added some comments. Let me know if you want more information

On Tue, Feb 1, 2022 at 4:16 PM Ethan Gutmann @.***> wrote:

I am trying to add some text based on the template, but I cannot figure out how I actually can edit that template … <#m-6498836607958341986>

Click the "..." in the top right of that box, then select edit

— Reply to this email directly, view it on GitHub https://github.com/NCAR/icar/pull/106#issuecomment-1027381634, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD24I5JIEOSZ5K7ZX32PXJTUZBSUPANCNFSM5M4GCK7Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

-- My working day may not be your working day. Please do not feel obliged to reply to this email outside of your normal working hours.

She/Her/Hers Dr. Trude Eidhammer Project Scientist II Research Applications Laboratory (RAL) National Center for Atmospheric Research (NCAR) P.O. Box 3000 Boulder, CO 80307-3000, USA

gutmann commented 2 years ago

Thanks, almost there. Can you edit the checklist, add this option to the run/complete_icar_options.nml and run/short_icar_options.nml. Also, add a couple of plots showing the change in SW and LW at the surface? (You had some you shared with me previously) You can just drag and drop an image into the comment box when you are editing it.

trudeeidhammer commented 2 years ago

I have updated the comments and the namelists.

On Thu, Feb 3, 2022 at 10:56 AM Ethan Gutmann @.***> wrote:

Thanks, almost there. Can you edit the checklist, add this option to the run/complete_icar_options.nml and run/short_icar_options.nml. Also, add a couple of plots showing the change in SW and LW at the surface? (You had some you shared with me previously) You can just drag and drop an image into the comment box when you are editing it.

— Reply to this email directly, view it on GitHub https://github.com/NCAR/icar/pull/106#issuecomment-1029250168, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD24I5PKKTYGEAGF4Y2RPNLUZK6UFANCNFSM5M4GCK7Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

-- My working day may not be your working day. Please do not feel obliged to reply to this email outside of your normal working hours.

She/Her/Hers Dr. Trude Eidhammer Project Scientist II Research Applications Laboratory (RAL) National Center for Atmospheric Research (NCAR) P.O. Box 3000 Boulder, CO 80307-3000, USA