NCAR / icar

The Intermediate Complexity Atmospheric Research model (ICAR)

MIT License

72 stars 53 forks source link

Bugfix: function argument type fix for Cray 9.1.0 #109

Closed scrasmussen closed 2 years ago

scrasmussen commented 2 years ago

TYPE: bug fix

KEYWORDS: function argument types

SOURCE: Soren Rasmussen, NCAR

DESCRIPTION OF CHANGES: Change of argument type from class to type so that argument variable types match and ICAR will build with Cray 9.1.0 on Cori at NERSC.

Checklist

[ ] Closes issue #xxxx
[ ] Tests added (unit tests and/or regression/integration tests)
[x] Backwards compatible
[ ] Requires new files? If so, how to generate them.
[ ] Fully documented

gutmann commented 2 years ago

After talking to Bert it wasn't clear if this actually fixes the issue completely. Are there more changes that need to be implemented still?

gutmann commented 2 years ago

@scrasmussen can you add the other change to the nx calculation to this PR?

scrasmussen commented 2 years ago

115 fixes the build issue on Cori. GNU compilers are now being used to build so this fix for the Cray compiler is not needed though it might be nice to add. Still unsure why every other compiler doesn't care about these changes, on Cray on Cori.