NCAR / icar

The Intermediate Complexity Atmospheric Research model (ICAR)
MIT License
72 stars 53 forks source link

Tweaks to physics drivers for different namelist combinations #123

Closed gutmann closed 2 years ago

gutmann commented 2 years ago

TYPE: bug fix

KEYWORDS: lsm init, physics driver, modern fortran

SOURCE: Ethan Gutmann, NCAR

DESCRIPTION OF CHANGES: Now checks more rigorously that arrays are allocated before assigning to them in the domain object initialization. Minor updates to tiedtke and noahmp to eliminate warnings at compile time. Updated lsm_driver code to correctly (or at least reasonably) handle both noahMP and NoahLSM when calculating 2m air temperature. Reduced some extra print statements to make runtime information easier to parse.

ISSUE: Fixes #121

TESTS CONDUCTED: tested with many different physics combinations lsm=0,3,4 mp=1,2,4,5 rad=2,3

Checklist