NCAR / icar

The Intermediate Complexity Atmospheric Research model (ICAR)
MIT License
72 stars 53 forks source link

Fix for potential temperature & relative humidity forcing combination #125

Closed gutmann closed 2 years ago

gutmann commented 2 years ago

TYPE: bug fix

KEYWORDS: forcing, computed variables, relative humidity

SOURCE: Ethan Gutmann, NCAR

DESCRIPTION OF CHANGES: Fix a problem that occurs if forcing data are provided with relative humidity and potential temperature. Previously ICAR would not convert potential temperature to real temperature before computing water vapor mixing ratio from relative humidity. This lead to some crazy results, not it checks what the form of temperature is before calculating humidity.

ISSUE: none

TESTS CONDUCTED: Ideal test case was run before and after change and output mixing ratios make sense now.

Checklist