KEYWORDS: SLEVE, gamma factor, batch submit scripts, ideal test case
SOURCE: Bert Kruyt, NCAR
DESCRIPTION OF CHANGES: One or more paragraphs describing problem, solution,
and required changes.
SLEVE: gamma factor was calculated incorrectly (did not account for n!=1). This did not have any effect on model functioning, only reported value at runtime was incorrect. Now the correct value is displayed on domain initialization.
Also, a bit more feedback in case of negative gamma is given.
Batch submit scripts: Changes suggested by Ethan w.r.t. previous PR have been incorporated.
gen_ideal.py & associated files: first implementation of more complex structures for ideal testcase. Now has the ability to generate more than one hill, and I've added more flexibility w.r.t. namelist options and topography. This will eventualy include an advection test modeled after the SLEVE paper by C.Schär et al 2002. But this requires some modification of the advection code (basically allowing the model to have QV without the advection code running). To be continued. The current implementation works fine though.
ISSUE:
Partially adresses comments to PR 124 (that I've closed, now you can just merge this one).
TESTS CONDUCTED:
Runs as before, no changes to dynamics, only diagnostic (apart from the ideal case that is).
Checklist
Merging the PR depends on following checklist being completed. Add X between
each of the square brackets if they are completed in the PR itself. If a
bullet is not relevant to you, please comment on why below the bullet.
[X ] Closes issue (PR124) (An issue must exist or be created to be closed. The
issue describes and documents the problem and general solution, the PR
describes the technical details of the solution.)
TYPE: bug fix, enhancement,
KEYWORDS: SLEVE, gamma factor, batch submit scripts, ideal test case
SOURCE: Bert Kruyt, NCAR
DESCRIPTION OF CHANGES: One or more paragraphs describing problem, solution, and required changes.
SLEVE: gamma factor was calculated incorrectly (did not account for n!=1). This did not have any effect on model functioning, only reported value at runtime was incorrect. Now the correct value is displayed on domain initialization. Also, a bit more feedback in case of negative gamma is given.
Batch submit scripts: Changes suggested by Ethan w.r.t. previous PR have been incorporated.
gen_ideal.py & associated files: first implementation of more complex structures for ideal testcase. Now has the ability to generate more than one hill, and I've added more flexibility w.r.t. namelist options and topography. This will eventualy include an advection test modeled after the SLEVE paper by C.Schär et al 2002. But this requires some modification of the advection code (basically allowing the model to have QV without the advection code running). To be continued. The current implementation works fine though.
ISSUE: Partially adresses comments to PR 124 (that I've closed, now you can just merge this one).
TESTS CONDUCTED: Runs as before, no changes to dynamics, only diagnostic (apart from the ideal case that is).
Checklist
Merging the PR depends on following checklist being completed. Add
Xbetween each of the square brackets if they are completed in the PR itself. If a bullet is not relevant to you, please comment on why below the bullet.