gutmann
commented
2 years ago Need to test with other recent changes, CI test is resulting in large potential temperature values, but something may be broken in CI tests. It builds and runs correctly, and prior offline tests looked good.
TYPE: enhancement, new feature
KEYWORDS: boundary layer, pbl, ysu, yonsei
SOURCE: Bert Kruyt, NCAR
DESCRIPTION OF CHANGES: Incorporated the ysu boundary layer physics scheme into ICAR. This included a new utilities/pbl_utlities.f90 to calculate two input terms for ysu. The routines in pbl_utlities were copied from WRF, I am not a 100% sure that is the best way to tackle this problem, but it seems to work. Feedback and critical review appreciated! As ysu calculates tendency terms for (amongst others) wind , the winds are re-balanced and dt is calculated after each pbl call in time_step.f90.
TESTS CONDUCTED: run on severeal cores/nodes and appears to be stable. Results indicate significant effects on 2m air T, surface winds, etc.
NOTES: As discussed with ethan, this also includes a modification to the noahMP call, were instead of dz_interface, dz_interface / 2. is now fed into the dz argument there. I am unsure of the physical interpretation of this, and if this is consistent with f.e. the apply_fluxes routine in lsm_driver, where the moisture flux calculation also includes a dz_i term that is left unchanged. Also, I noticed that in the recent version of WRF, the ysu code has been slightly modified. These modifications have not yet been incorporated here in ICAR.
Checklist
Merging the PR depends on following checklist being completed. Add
Xbetween each of the square brackets if they are completed in the PR itself. If a bullet is not relevant to you, please comment on why below the bullet.