NCAR / icar

The Intermediate Complexity Atmospheric Research model (ICAR)
MIT License
72 stars 53 forks source link

Issue 146 bugfix: costheta and sintheta calculations #149

Closed scrasmussen closed 1 year ago

scrasmussen commented 1 year ago

TYPE: bug fix

KEYWORDS: wind fields, latitude, longitude, boundary conditions

SOURCE: Soren Rasmussen, NCAR

DESCRIPTION OF CHANGES: Costheta and sintheta calculations were different when using one vs. multiple processes. To fix this lat and long fields are copied to global variables until costheta and sintheta are calculated. Slight changes to the bounds of certain calculations have been made

ISSUE: Fixes #146

TESTS CONDUCTED: Comparing results from original code, 1 vs. 36 images to the PR.

image

Checklist

gutmann commented 1 year ago

very cool, I love how simple that change is in the end!