NCAR / icar

The Intermediate Complexity Atmospheric Research model (ICAR)
MIT License
72 stars 53 forks source link

Fix/cmip stability v2.1.1 #150

Closed gutmann closed 1 year ago

gutmann commented 1 year ago

TYPE: enhancement

KEYWORDS: pressure interpolation, forcing, sst, external precipitation, relative humidity

SOURCE: Ethan Gutmann, NCAR

DESCRIPTION OF CHANGES: This PR fixed a possible pressure interpolation bug and generally improved pressure vertical interpolation process significantly (note this can change precipitation, so far it seems to be an improvement) This also adds namelist options to limit the relative humidity in the forcing data to, e.g. 120%, the minimum SST in the forcing to, e.g. 273.15K, and the maximum prescribed convective precipitation. All limit values are namelist options.

TESTS CONDUCTED: Ran multiple western US tests. Tested model simulations that used to break as a result of bad pressure interpolation. Tested that setting the SST, RH, or CP limits to very restrictive settings changed the simulations correctly.

Checklist