DESCRIPTION OF CHANGES: makefile: water_simple now depends on options_h. Apparently gnu was ok without it, but cray is not.
NoahMP: an error check in NoahMP that compares SWDOWN (downward solar filtered by sun angle [w/m2]) to the sum of FSA ( total absorbed solar radiation (w/m2)) and FSR (total reflected solar radiation (w/m2)) gives an error if the difference is more than 0.01 W/m2. When compiled with cray, this condition is too stringent and the error is triggered. I increased the threshold to 0.1 W/m2.
TESTS CONDUCTED: runs - havent checked results but unlikely that <0.1 W/m2 makes a difference. Compiles with gfortran as well as cray (on Perlmutter)
Checklist
Merging the PR depends on following checklist being completed. Add X between
each of the square brackets if they are completed in the PR itself. If a
bullet is not relevant to you, please comment on why below the bullet.
[ ] Closes issue #xxxx (An issue must exist or be created to be closed. The
issue describes and documents the problem and general solution, the PR
describes the technical details of the solution.)
TYPE: bug fix
KEYWORDS: Cray, NoahMP, precision, compiler
SOURCE: Bert Kruyt, NCAR, RAL
DESCRIPTION OF CHANGES: makefile: water_simple now depends on options_h. Apparently gnu was ok without it, but cray is not. NoahMP: an error check in NoahMP that compares SWDOWN (downward solar filtered by sun angle [w/m2]) to the sum of FSA ( total absorbed solar radiation (w/m2)) and FSR (total reflected solar radiation (w/m2)) gives an error if the difference is more than 0.01 W/m2. When compiled with cray, this condition is too stringent and the error is triggered. I increased the threshold to 0.1 W/m2.
TESTS CONDUCTED: runs - havent checked results but unlikely that <0.1 W/m2 makes a difference. Compiles with gfortran as well as cray (on Perlmutter)
Checklist
Merging the PR depends on following checklist being completed. Add
X
between each of the square brackets if they are completed in the PR itself. If a bullet is not relevant to you, please comment on why below the bullet.