Add advection changes which should have been part of HICAR PR#1 Advection

NCAR / icar

The Intermediate Complexity Atmospheric Research model (ICAR)

MIT License

72 stars 53 forks source link

Add advection changes which should have been part of HICAR PR#1 Advection #159

Closed d-reynolds closed 1 year ago

d-reynolds commented 1 year ago

TYPE: bug fix

KEYWORDS: advection, jacobian, fixed_dz_advection

SOURCE: Dylan Reynolds, SLF

DESCRIPTION OF CHANGES: Added a few changes which should have been included in the prior HICAR advection PR. These involve a handling of varying halo sizes when using halo_subset with the microphysics code, the selection of halo_size, the calculation of the jacobian on the vertical staggered grid, and removing the option to use fixed_dz_advection (this should never be false)

gutmann commented 1 year ago

You might need to test how this works with directories, but I think you can add .ipynb_checkpoints to the .gitignore file and it will stop adding them.