NCAR / joai-project

jOAI is an OAI-PMH data provider and harvester Java web application
Apache License 2.0
16 stars 9 forks source link

feat: add docker container for this app #4

Closed tomsaleeba closed 5 years ago

tomsaleeba commented 5 years ago

This PR is to satisfy https://github.com/NCAR/joai-project/issues/3.

The docker build process will build the code that is in your working directory (as opposed to pulling a binary from some URL). This means you can test development changes in the docker container.

UTF-8 I found I had to add encoding="UTF-8" to the build.xml otherwise the following error would happen:

  [javadoc] /tmp/joai-project/src/org/apache/commons/collections/ValueSortedMap.java:9: error: unmappable character for encoding ASCII
  [javadoc]  *  Code posted by Stefan Fu??enegger was taken from http://techblog.molindo.at/2008/11/java-map-sorted-by-value.html

Hopefully this doesn't adversely affect how you usually build the app outside of docker.

Auto building You might want to consider using https://cloud.docker.com/ to automatically build the docker image on code pushes. It's free and it'll make it easy for people to use your image (they won't have to pull the code and build it themselves). I've found only building on git tag pushes with Docker cloud settings like the following: selection_109 ...works nicely. Only releases are built and they're tagged with the git tag version. The only downside is you can't version the docker container independently of the jOAI software version.