NCAR / mam

A modal aerosol model
Apache License 2.0
2 stars 0 forks source link

make wavelength bounds configuration data #9

Closed mattldawson closed 3 years ago

mattldawson commented 3 years ago

Remove hard-coded wavelength bounds. Move to configuration

AndrewJConley commented 3 years ago

The wavelength bounds for RRTMG are hardwired.

I also think the band boundaries for MAM optics tables are hardwired as well. Since those tables are computed based on rrtmg bands, removing the bounds may be difficult, unless you have the code and data that was used to create the tables

Andrew

On Aug 27, 2021, at 2:00 PM, Matt Dawson @.***> wrote:

 Remove hard-coded wavelength bounds. Move to configuration

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

mattldawson commented 3 years ago

Hi Andrew!

I should have been more specific, this is just the MAM wavelength bounds, not RRTMG.

I was thinking of moving the MAM wavelength bounds to the NetCDF files that hold the optical property lookup table data, since they are related. This way if someone wanted to change the bounds and recalculate the optics tables, they would just need to swap out the NetCDF file. They would have to follow whatever procedures exist for updating the RRTMG bounds if they wanted these to continue to match the MAM wavelengths, but this would at least make the MAM configuration more straightforward, imo.

AndrewJConley commented 3 years ago

Excellent. That makes sense!

Andrew

On Aug 27, 2021, at 2:22 PM, Matt Dawson @.***> wrote:

 Hi Andrew!

I should have been more specific, this is just the MAM wavelength bounds, not RRTMG.

I was thinking of moving the MAM wavelength bounds to the NetCDF files that hold the optical property lookup table data, since they are related. This way if someone wanted to change the bounds and recalculate the optics tables, they would just need to swap out the NetCDF file. They would have to follow whatever procedures exist for updating the RRTMG bounds if they wanted these to continue to match the MAM wavelengths, but this would at least make the MAM configuration more straightforward, imo.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.