Two different version of Chapman configurations coexist

NCAR / micm

A model-independent chemistry module for atmosphere models

https://ncar.github.io/micm/

Apache License 2.0

5 stars 5 forks source link

Two different version of Chapman configurations coexist #368

Closed boulderdaze closed 4 months ago

boulderdaze commented 12 months ago

There are two different version of Chapman configuration, one kpp version and the other music box interactive version

Ideas

Leave the version of Chapman that is in the examples folder, because it is the most correct version
Add a README to the test/unit/unit_configs/ folder to indicate that all the configurations in this folder are for internal testing and should not be used for actual simulations.

mattldawson commented 5 months ago

I like the second idea. I think some things have been added to the Chapman mechanism in the tests that aren't scientifically correct, but are used to test specific parts of the configuration reader.

We could also rename the mechanism in the tests to something other than Chapman to make it clear that it is not really a usable configuration