search

NCAR / micm

A model-independent chemistry module for atmosphere models
https://ncar.github.io/micm/
Apache License 2.0
6 stars 5 forks source link

416 add assignment overridescopy constructors to cudavectormatrix so new matrix has separate device memory #420

Closed mwaxmonsky closed 8 months ago

mwaxmonsky commented 8 months ago

Adds assignment and move operators and constructors so a CudaVectorMatrix can be assigned to another which generates new device data for the newly assigned vector or moves the other vector into the new vector while in that case taking ownership of the other matrix's device memory.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.66%. Comparing base (9416a2f) to head (6bda461). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #420 +/- ## ======================================= Coverage 94.66% 94.66% ======================================= Files 38 38 Lines 3057 3057 ======================================= Hits 2894 2894 Misses 163 163 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mwaxmonsky commented 8 months ago

Thanks @mwaxmonsky for fixing this issue. All the tests passed on Derecho's GPU.

Would it be helpful to add some comments about the overrided operator?

Is this in regards to the 4 move/copy assignment/constructors? If so, after talking with @mattldawson, it sounds like we don't want to add comments stating what each operator/constructor is since they are inferred by their signature.

But if this is in relation to different comments, just let me know and I'd be happy to add it!