search

NCAR / micm

A model-independent chemistry module for atmosphere models
https://ncar.github.io/micm/
Apache License 2.0
5 stars 5 forks source link

Rename CUDA matrix class to be Dense or Sparse #443

Closed sjsprecious closed 5 months ago

sjsprecious commented 5 months ago

This PR renames the previous CudaVectorMatrix class to CudaDenseMatrix class for clarity. Now we only have CudaDenseMatrix and CudaSparseMatrix, and they are only for the vector matrix on GPU.

Maybe we should highlight somewhere that the GPU code only works with the vector matrix?

All the 40 tests passed on Derecho's A100 GPU by using nvhpc/23.7.

Fixed #442

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.65%. Comparing base (690b5c6) to head (0f5ba61).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #443 +/- ## ======================================= Coverage 94.65% 94.65% ======================================= Files 38 38 Lines 3051 3051 ======================================= Hits 2888 2888 Misses 163 163 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.