search

NCAR / micm

A model-independent chemistry module for atmosphere models
https://ncar.github.io/micm/
Apache License 2.0
5 stars 5 forks source link

Update the CUDA implementation of AlphaMinusJacobian and NormalizedError with the CUDA matrix class #452

Closed sjsprecious closed 4 months ago

sjsprecious commented 5 months ago

This PR updates the input type for the CUDA implementation of AlphaMinusJacobian and NormalizedError functions with the CudaDenseMatrix and CudaSparseMatrix class.

It also addresses some issues related to the copy/move constructor/assignment/destructor in the CudaDenseMatrix and CudaSparseMatrix class.

All the 41 tests all passed on Derecho's A100 GPU by using nvhpc/23.7.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.62%. Comparing base (a833afc) to head (d440ff4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #452 +/- ## ======================================= Coverage 94.62% 94.62% ======================================= Files 38 38 Lines 3107 3107 ======================================= Hits 2940 2940 Misses 167 167 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.