search

NCAR / micm

A model-independent chemistry module for atmosphere models
https://ncar.github.io/micm/
Apache License 2.0
6 stars 4 forks source link

456 read and use relative tolerance absolute tolerance #457

Closed K20shores closed 4 months ago

K20shores commented 4 months ago

Closes #456

Reads the relative tolerance on the solver config and sets it on a set of parameters. Uses the absolute tolerance for each species and sets it individually if it's present

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 86.84211% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 94.34%. Comparing base (3be56e2) to head (54d1873). Report is 2 commits behind head on main.

Files Patch % Lines
include/micm/solver/rosenbrock.inl 71.42% 4 Missing :warning:
include/micm/configure/solver_config.hpp 93.75% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #457 +/- ## ========================================== - Coverage 94.61% 94.34% -0.28% ========================================== Files 38 38 Lines 3102 3130 +28 ========================================== + Hits 2935 2953 +18 - Misses 167 177 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sjsprecious commented 4 months ago

@K20shores can you merge in the latest main branch so that I could check whether all the GPU tests pass on Derecho? Thanks.