search

NCAR / micm

A model-independent chemistry module for atmosphere models
https://ncar.github.io/micm/
Apache License 2.0
6 stars 4 forks source link

Explicitly call the function from the base class in a CUDA class #483

Closed sjsprecious closed 3 months ago

sjsprecious commented 3 months ago

This PR makes all the CUDA class explicitly call the functions from the base class if the input argument is not a CUDA matrix. This helps confuse the compiler less.

All the 42 tests all passed on Derecho's A100 GPU by using nvhpc/23.7.

Since this branch is based on the update_cuda_matrix_class_for_cuda_linear_solver branch, there are lots of duplicated changes from PR #474 before that PR is merged.

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.32%. Comparing base (648af42) to head (44680c0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #483 +/- ## ======================================= Coverage 93.32% 93.32% ======================================= Files 40 40 Lines 3177 3177 ======================================= Hits 2965 2965 Misses 212 212 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.