NCAR / micm

A model-independent chemistry module for atmosphere models
https://ncar.github.io/micm/
Apache License 2.0
6 stars 4 forks source link

Rename functions to consistently use CamelCase #489

Closed boulderdaze closed 3 months ago

boulderdaze commented 3 months ago

Closes #480

While working on this issue, some of the suggestions under readability check category were applied, considered as easy fix.

The disabled or undecided checks in readability category are listed with the comments for the discussion in .clang-tidy

I put aside an issue for updating tutorials to reflect the new names. This task can be done when applying the style and renaming is completed

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 94.48819% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 93.33%. Comparing base (ada3263) to head (8cad3c7).

Files Patch % Lines
include/micm/process/rate_constant.hpp 0.00% 2 Missing :warning:
include/micm/solver/jit_linear_solver.inl 75.00% 2 Missing :warning:
include/micm/process/process.hpp 90.90% 1 Missing :warning:
include/micm/process/surface_rate_constant.hpp 66.66% 1 Missing :warning:
...nclude/micm/process/user_defined_rate_constant.hpp 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #489 +/- ## ======================================= Coverage 93.32% 93.33% ======================================= Files 40 40 Lines 3177 3179 +2 ======================================= + Hits 2965 2967 +2 Misses 212 212 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.