Closed boulderdaze closed 3 months ago
Attention: Patch coverage is 94.48819%
with 7 lines
in your changes are missing coverage. Please review.
Project coverage is 93.33%. Comparing base (
ada3263
) to head (8cad3c7
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closes #480
While working on this issue, some of the suggestions under
readability
check category were applied, considered as easy fix.public
keywords (readability-redundant-access-specifiers
)readability-inconsistent-declaration-parameter-name
)void LuDecomposition::Initialize(const SparseMatrixPolicy& A, T initial_value)
void LuDecomposition::Initialize(const SparseMatrixPolicy& matrix, T initial_value)
Set
prefix to the functions that have the sameclass
name to avoid usingclass
tag e.g.,ProcessBuilder& Phase(const Phase& phase)
[error] must use class tag to refer to typePhase
in this scope. ->ProcessBuilder& SetPhase(const Phase& phase)
The disabled or undecided checks in
readability
category are listed with the comments for the discussion in.clang-tidy
I put aside an issue for updating tutorials to reflect the new names. This task can be done when applying the style and renaming is completed