search

NCAR / micm

A model-independent chemistry module for atmosphere models
https://ncar.github.io/micm/
Apache License 2.0
6 stars 4 forks source link

Fix the profiler driver #493

Closed boulderdaze closed 2 months ago

boulderdaze commented 2 months ago

Closes #490

Removed the outdated ConfigParseStatus Added it to the git actions

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.32%. Comparing base (9c86cc8) to head (9315659).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #493 +/- ## ======================================= Coverage 93.32% 93.32% ======================================= Files 40 40 Lines 3177 3177 ======================================= Hits 2965 2965 Misses 212 212 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

boulderdaze commented 2 months ago

Does this get run in any of the github actions?

Looks like it doesn't. If MICM_ENABLE_PROFILE is ON, the executable is created but the default is OFF unlike MICM_ENABLE_EXAMPLES, which makes sense. I'd like to have it added to the github actions but am not sure which is the best way to do. Creating a docker for this could be easier but am not sure that's what we want to do. What do you think?

K20shores commented 2 months ago

@boulderdaze I think it makes sense to add this option to the mac, ubuntu, and windows actions

boulderdaze commented 2 months ago

@boulderdaze I think it makes sense to add this option to the mac, ubuntu, and windows actions

boulderdaze commented 2 months ago

@boulderdaze I think it makes sense to add this option to the mac, ubuntu, and windows actions

Yes, I updated it. Could you review them once more?