NCAR / micm

A model-independent chemistry module for atmosphere models
https://ncar.github.io/micm/
Apache License 2.0
5 stars 5 forks source link

Re-evaluate clang tidy #501

Closed mwaxmonsky closed 5 months ago

mwaxmonsky commented 5 months ago

Adds a clang-tidy workflow to static analyze most of the micm source code with a few exceptions noted in the filters in the workflow file.

Mostly required adding includes that were missing to compile the file in isolation and one template call fix in cuda_linear_solver.hpp.

Currently only uses the bugprone-* check for proof of concept but will open a discussion with documentation and use cases for other checks that can be turned on later.

Manually configures the configuration at the command line but will integrate with and further modify the .clang-tidy config file in #489 at a later date for consistency.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.90%. Comparing base (a803ff0) to head (1a9ac89).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #501 +/- ## ======================================= Coverage 92.90% 92.90% ======================================= Files 42 42 Lines 3268 3268 ======================================= Hits 3036 3036 Misses 232 232 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

K20shores commented 5 months ago

@mwaxmonsky would you please file an issue detailing anything that's outstanding (like using or removing the cmake clang tidy stuff, and integrating your checks with the clang tidy file)?

mwaxmonsky commented 5 months ago

@mwaxmonsky would you please file an issue detailing anything that's outstanding (like using or removing the cmake clang tidy stuff, and integrating your checks with the clang tidy file)?

Yup! Started working on it this morning and will push up a generic issue similar to the GPU resident checklist issue with all of the issues linked.