search

NCAR / micm

A model-independent chemistry module for atmosphere models
https://ncar.github.io/micm/
Apache License 2.0
6 stars 4 forks source link

Update CMakeLists.txt to support latest CUDA project type and architectures #546

Closed mwaxmonsky closed 1 month ago

mwaxmonsky commented 1 month ago

Is your feature request related to a problem? Please describe. Current implementation hard codes sm80 so this will not be usable on v100s or h100s.

Describe the solution you'd like A flag that turns on a particular version or set of supported gpu architectures.

Describe alternatives you've considered N\A

Additional context N\A

sjsprecious commented 1 month ago

I think this issue is fixed by my changes here (https://github.com/NCAR/micm/blob/428-singleton-for-cublas-handle/src/CMakeLists.txt#L55-L64) but let me know if you think it is not enough.

mwaxmonsky commented 1 month ago

I think this issue is fixed by my changes here (https://github.com/NCAR/micm/blob/428-singleton-for-cublas-handle/src/CMakeLists.txt#L55-L64) but let me know if you think it is not enough.

That should work! I just pushed up #547 actually so apologies for not getting that up sooner! It should mitigate needing to change that CMakeLists.txt if it's reasonable.