Closed mwaxmonsky closed 1 month ago
Lots of red. Beautiful! and I like the completeness of the architectures
I wanted more red but CMake isn't quite there for CUDA yet. :(
I also was thinking would it make sense to add a default architecture if none is provided (ie. if MICM_GPU_TYPE
is not set but MICM_ENABLE_CUDA
is, maybe set MICM_GPU_ARCH=all-major
?) (https://cmake.org/cmake/help/latest/prop_tgt/CUDA_ARCHITECTURES.html)
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.25%. Comparing base (
555be4e
) to head (550e8fd
). Report is 4 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks @sjsprecious!
@K20shores, when you have a sec, could you take another look at these changes? We changed some of the core logic a bit more and just wanted to make sure it looked okay to you.
Simplifies CMake infrastructure by removing openACC support and modernizes CUDA integration with CMake.
Closes #546