NCAR / micm

A model-independent chemistry module for atmosphere models
https://ncar.github.io/micm/
Apache License 2.0
6 stars 4 forks source link

546 update cmakeliststxt to support latest cuda project type and architectures #547

Closed mwaxmonsky closed 1 month ago

mwaxmonsky commented 1 month ago

Simplifies CMake infrastructure by removing openACC support and modernizes CUDA integration with CMake.

Closes #546

mwaxmonsky commented 1 month ago

Lots of red. Beautiful! and I like the completeness of the architectures

I wanted more red but CMake isn't quite there for CUDA yet. :(

I also was thinking would it make sense to add a default architecture if none is provided (ie. if MICM_GPU_TYPE is not set but MICM_ENABLE_CUDA is, maybe set MICM_GPU_ARCH=all-major?) (https://cmake.org/cmake/help/latest/prop_tgt/CUDA_ARCHITECTURES.html)

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.25%. Comparing base (555be4e) to head (550e8fd). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #547 +/- ## ======================================= Coverage 92.25% 92.25% ======================================= Files 45 45 Lines 3407 3407 ======================================= Hits 3143 3143 Misses 264 264 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mwaxmonsky commented 1 month ago

Thanks @sjsprecious!

@K20shores, when you have a sec, could you take another look at these changes? We changed some of the core logic a bit more and just wanted to make sure it looked okay to you.