NCAR / micm

A model-independent chemistry module for atmosphere models

https://ncar.github.io/micm/

Apache License 2.0

6 stars 4 forks source link

Modify regex in clang format #559

Closed boulderdaze closed 3 weeks ago

boulderdaze commented 4 weeks ago

Modify regex in clang format

IndentPPDirectives: AfterHash: current

#if FOO
#  if BAR
#    include <foo>
#  endif
#endif

IndentPPDirectives: BeforeHash: this PR
```
#if FOO
#if BAR
#include <foo>
#endif
#endif
```
The current REGEX failed to list an external header with - above system headers. (The example is from tuvx, which I found the failure.) Current:
```
#include <tuvx/util/config_yaml.h>
```

include

include <yaml-cpp/yaml.h>

This PR:
```c++: 
#include <tuvx/util/config_yaml.h>

#include <yaml-cpp/yaml.h>

#include <cstring>
#include <fstream>

codecov-commenter commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.21%. Comparing base (555be4e) to head (2af8e83). Report is 10 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #559 +/- ## ========================================== - Coverage 92.25% 92.21% -0.04% ========================================== Files 45 45 Lines 3407 3403 -4 ========================================== - Hits 3143 3138 -5 - Misses 264 265 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mwaxmonsky commented 3 weeks ago

@boulderdaze, could you update the description with a few examples of what will change when the format bot runs after this change?

boulderdaze commented 3 weeks ago

@boulderdaze, could you update the description with a few examples of what will change when the format bot runs after this change?

Yes, that's a good idea. I updated the comments with the examples.

mwaxmonsky commented 3 weeks ago

@boulderdaze, could you update the description with a few examples of what will change when the format bot runs after this change?

Yes, that's a good idea. I updated the comments with the examples.

Thank you!