NCAR / micm

A model-independent chemistry module for atmosphere models
https://ncar.github.io/micm/
Apache License 2.0
5 stars 5 forks source link

Check for singularity when the solver parameters flag is turned on #572

Closed mattldawson closed 2 months ago

mattldawson commented 3 months ago

There is a flag in RosenbrockSolverParameters to allow checking for singularity, but it currently doesn't do anything. Check for singularity when this flag is enabled.

Acceptance Criteria

Ideas

K20shores commented 2 months ago

We already have singularity checks. They are present in the LU Decomposition, so I don't think we need to change the Factor function. But we do have to change the LinearFactor function in rosenbrock to actually use the singularity check that we already have