Test all solvers against Robertson tests

NCAR / micm

A model-independent chemistry module for atmosphere models

https://ncar.github.io/micm/

Apache License 2.0

5 stars 5 forks source link

Test all solvers against Robertson tests #575

Closed K20shores closed 2 months ago

K20shores commented 3 months ago

All of the mentioned tests are very stiff systems.

Acceptance Criteria

[x] CPU Rosenbrock passes all these analytical tests (dense matrix)
[x] CPU Rosenbrock passes all these analytical tests (vector matrix)
[x] CPU JIT Rosenbrock passes all these analytical tests
[x] GPU Rosenbrock passes all these analytical tests

K20shores commented 3 months ago

@sjsprecious do you think it's worth testing the cuda solver against these analytical tests? We'd have to write cuda kernels fro E5, Oregonator, and HIRES

sjsprecious commented 3 months ago

@K20shores possibly not if they require a specific implementation of CUDA kernels. I think it is enough if we can get all the CUDA tests that are covered by the JIT tests working. This is just my two cents.

K20shores commented 3 months ago

@sjsprecious I'll change it to just the robertson tests then; it won't require kernels

K20shores commented 2 months ago

Closed by #596 when the vector tests were added to analytical policy