codecov-commenter
commented
1 week ago Codecov Report
Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
Project coverage is 93.27%. Comparing base (
ab3b32a) to head (add95c2).
| Files | Patch % | Lines |
|---|---|---|
| include/micm/solver/solver_result.hpp | 0.00% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #582 +/- ## ========================================== + Coverage 92.92% 93.27% +0.35% ========================================== Files 49 49 Lines 3462 3466 +4 ========================================== + Hits 3217 3233 +16 + Misses 245 233 -12 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closes #498
This also tests backward euler against hires and e5. The oregonator systems is apparently too stiff for backward euler.
From my understanding, if you fail to converge too many times in a row and try to cut the time step too many times in camchem, you forgo the current integration, but accept what you have done up to the last successful integration and continue on.
I don't actually know how to test this