search

NCAR / micm

A model-independent chemistry module for atmosphere models
https://ncar.github.io/micm/
Apache License 2.0
5 stars 5 forks source link

In-place linear solve #585

Closed K20shores closed 3 months ago

K20shores commented 3 months ago

Closes #492

Solving $Ax=B$ with the linear solve can be done in place. $x$ was always a copy of $b$ and we would copy $b$ into places in the linear solve. This removes the $b$ argument from all versions of the linear solver and reduces the memory footprint by one matrix

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.90%. Comparing base (7e9c883) to head (9aa9e95).

:exclamation: Current head 9aa9e95 differs from pull request most recent head 1f4faf4

Please upload reports for the commit 1f4faf4 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #585 +/- ## ========================================== - Coverage 92.91% 92.90% -0.01% ========================================== Files 49 49 Lines 3485 3468 -17 ========================================== - Hits 3238 3222 -16 + Misses 247 246 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.