NCAR / micm

A model-independent chemistry module for atmosphere models
https://ncar.github.io/micm/
Apache License 2.0
6 stars 4 forks source link

Check if resetting the L and U matrices before solving with Rosenbrock is needed #587

Closed mattldawson closed 4 days ago

mattldawson commented 1 week ago

Currently the lower and upper matrices on the State are reset to zero at the beginning of the Rosenbrock solve, but this shouldn't actually be necessary. It was likely just causing an error before the normalized error function was set to properly work with vectorizable matrices where the number of grid cells was not even divisible by the vector dimension. See if this can be removed now.

Acceptance Criteria

K20shores commented 1 week ago

Added in this PR (kyle can't remember why, but was doing lots of work in the performance repo at the time and some repeated calls were causing issues, maybe in the benchmarking)