NCAR / micm

A model-independent chemistry module for atmosphere models
https://ncar.github.io/micm/
Apache License 2.0
6 stars 4 forks source link

absolute tolerance error checking #599

Closed K20shores closed 2 weeks ago

K20shores commented 1 month ago

During #593 I several times provided a vector of absolute_tolerance_s to the rosenbrock parameters that were a different length than what was needed. The solver still ran but I don't know what tolerances it ended up using in those errant cases

It looks like we don't set tolerances when we don't provide the right length. But it also looks like we don't set any tolerances in that case.

https://github.com/NCAR/micm/blob/46d0a7484dea276e81e3f423b2efd44324e300ee/include/micm/solver/solver_builder.inl#L286-L310

Investigate if this is true and fix it if so

Acceptance criteria