search

NCAR / music-box-interactive-client

Static pages for the MusicBox front end
https://musicbox.acom.ucar.edu
Apache License 2.0
3 stars 11 forks source link

Aerosol Phases can't be deleted #314

Closed HunterLikeFarmer closed 2 months ago

HunterLikeFarmer commented 3 months ago

Describe the bug When you add phases into the aerosol phase tab, they can not be deleted. (the reason could be the inappropriate reuse of list component)

To Reproduce Steps to reproduce the behavior:

  1. Go to 'mechanism sidebar section'
  2. Click on 'aerosol' tab and then 'phase' tab
  3. Add any phases
  4. You will be unable to delete the phase by clicking on the cross

Expected behavior It's supposed to be deleted just the way species can be deleted: after deleting, the phase will no appear on the menu and the redux store.

Screenshots Screenshot 2024-07-23 191227

nipun-sachintha commented 3 months ago

I have worked on this. fix here https://github.com/NCAR/music-box-interactive-client/pull/318