NCAR / music-box

A box/column model using MICM chemistry
https://ncar.github.io/music-box/branch/main/
Apache License 2.0
14 stars 9 forks source link

Some examples in music-box-interactive-api do not run correctly under Musica 0.7.3 #187

Closed carl-drews closed 1 month ago

carl-drews commented 1 month ago

Some of the JSON configurations are not compatible with the python music-box and musica 0.7.3. For example, I made these corrections while testing:

--- a/interactive/api/static/examples/FLOW_TUBE/camp_data/config.json +++ b/interactive/api/static/examples/FLOW_TUBE/camp_data/config.json @@ -1,7 +1,7 @@ { "camp-files" : [

--- a/interactive/api/static/examples/FLOW_TUBE/camp_data/species.json +++ b/interactive/api/static/examples/FLOW_TUBE/camp_data/species.json @@ -3,8 +3,7 @@ { "name": "M", "type": "CHEM_SPEC",

That is not an exhaustive list. Do we desire to make these corrections now or later?

carl-drews commented 1 month ago

See also: Validate all configuration in MusicBox curriculum examples #161 https://github.com/NCAR/music-box/issues/161

K20shores commented 1 month ago

Music box interactive (specifically the API server) generates (and stores) configurations with the path camp_data/species.json. We need to decide if we need to make music-box conform to the api server, or the other way around. @mattldawson what do you think?

K20shores commented 1 month ago

All examples are now passing on main