NCAR / musica

Multi-Scale Infrastructure for Chemistry Modeling
https://wiki.ucar.edu/display/MUSICA/MUSICA+Home
Apache License 2.0
3 stars 2 forks source link

Make tuvx grids available in musica fortran and musica c++ #140

Closed K20shores closed 2 weeks ago

K20shores commented 1 month ago

Closes #120, #146, also relies on https://github.com/NCAR/tuv-x/pull/90 and https://github.com/NCAR/tuv-x/pull/96 Apparently also closes #108

What I don't have, as of submission, is a test that checks for data being set properly because I don't know if we want to do what I did (which is copy the memory). If we stick with that, we will need a getter which will return a copy(?) to the external facing forcing and then we can check.

An alternative is to pass only the pointer around so that the memory is shared completely between fortran->C++->fortran. That seems like a bit problem waiting to happen though.

Should I create the getter or share the memory?