Update MICM wrapper to use SolverBuilder - Githubissues

NCAR / musica

Multi-Scale Infrastructure for Chemistry Modeling

https://wiki.ucar.edu/display/MUSICA/MUSICA+Home

Apache License 2.0

3 stars 2 forks source link

Update MICM wrapper to use SolverBuilder #146

Closed mattldawson closed 2 weeks ago

mattldawson commented 3 weeks ago

Update the MICM wrapper code to use the new SolverBuilder class to create instances of the Rosenbrock solver.

Acceptance Criteria

MUSICA tests pass when linking against the latest commit on main in the MICM repo

Ideas

Update the creation of the Rosenbrock solver here: https://github.com/NCAR/musica/blob/d09c3befe111c8a2de1aefbc4d43c40f5122f690/src/micm/micm.cpp#L171-L179

to use the same logic as in the MICM tests: https://github.com/NCAR/micm/blob/f8f46dfac286cd5e2227537d04ff9c48c08a0ae9/test/unit/solver/test_solver_builder.cpp#L90-L95

K20shores commented 2 weeks ago

Fixed by #140