NCAR / musica

Multi-Scale Infrastructure for Chemistry Modeling
https://ncar.github.io/musica/
Apache License 2.0
6 stars 3 forks source link

Remove fetch content integration #185

Closed boulderdaze closed 1 month ago

boulderdaze commented 2 months ago

The purpose of the fetch content is to support cross-compiling but musica doesn't have that requirement anymore

Ideas

mattldawson commented 2 months ago

I think we still need to support cross-compiling - it's the only way the JIT-compiled code (and maybe the CUDA code also?) can be used with a fortran wrapper compiled with intel compilers

boulderdaze commented 2 months ago

I haven't thought about JIT-compiled code. Do you agree @K20shores? If we all are on the same page, I will delete the issue.

K20shores commented 2 months ago

@mattldawson @boulderdaze Could we just rework the tests so that we test cross compiling directly? I just think testing fetch content makes it hard to correctly test the current branch and we don't need to be testing if cmake's stuff works

boulderdaze commented 1 month ago

Yeah, I agree it makes hard to test the current branch. I think we can remove the fetch content part from the current test setup and keep the cross compiling test

boulderdaze commented 1 month ago

We think using fetch content is simpler to support cross compiling test. Closing the issue.