search

NCAR / ncl

The NCAR Command Language (NCL) is a scripting language for the analysis and visualization of climate and weather data.
http://www.ncl.ucar.edu
Other
261 stars 65 forks source link

Bug with function wrf_updraft_helicity and wrf_user_getvar(a,"updraft_helicity",-1) #62

Open huangynj opened 5 years ago

huangynj commented 5 years ago

Hi NCL Team,

I found some bugs with function wrf_updraft_helicity and wrf_user_getvar(a,"updraft_helicity",-1).

  1. The argument ZP in wrf_updraft_helicity should be geopotential height (m) not geopotential (m-2/s-2);

  2. In the code https://github.com/huangynj/ncl/blob/master/ni/src/lib/nfpfort/calc_uh.f90#L155 : "uh = uh * 1000. ! Scale according to Kain et al. (2008)" should be deleted;

  3. So in function wrf_user_getvar, when calculating "updraft_helicity", "zp = zp/9.81" should be added after https://github.com/NCAR/ncl/blob/master/ni/src/examples/gsun/WRFUserARW.ncl#L1510.

Please confirm!

Yongjie Huang OU/MAP

bladwig1 commented 5 years ago

This is fixed in the upcoming release. It is already available in WRF-Python if you need something immediately.