search

NCAR / noahmp

Noah-MP Community Repository
Other
72 stars 81 forks source link

AtmosForcingMod, OptRainSnowPartition == 5 update for warm instances #112

Closed RAbolafiaRosenzweig closed 9 months ago

RAbolafiaRosenzweig commented 9 months ago

Update to set FrozenPrecipFrac = 0.0 for instances of TemperatureAirRefHeight>=10C to avoid numerical errors in rain/snowfall partitioning calculation for warm instances when OptRainSnowPartition == 5.

cenlinhe commented 9 months ago

@RAbolafiaRosenzweig next time, you may want to use a more informative commit message/title when you update the code files. Currently, all your commit messages are showing "Add files via upload". Also, next time, you may want to try directly modify the github code on your local machine and then commit the change and submit the change to your forked github online and then create the PR. In this way, you do not need to upload files separately.

RAbolafiaRosenzweig commented 9 months ago

Thank you for these notes. I will make sure to have more detailed comments and consider directly updating github code in future instances.

-Ronnie

On Fri, Feb 2, 2024 at 9:02 AM Cenlin_He @.***> wrote:

@RAbolafiaRosenzweig https://github.com/RAbolafiaRosenzweig next time, you may want to use a more informative commit message/title when you update the code files. Currently, all your commit messages are showing "Add files via upload". Also, next time, you may want to try directly modify the github code on your local machine and then commit the change and submit the change to your forked github online and then create the PR. In this way, you do not need to upload files separately.

— Reply to this email directly, view it on GitHub https://github.com/NCAR/noahmp/pull/112#issuecomment-1924167217, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIXTHJG7FUGOMIPUQDXHUPLYRUEZJAVCNFSM6AAAAABCW4L5IOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRUGE3DOMRRG4 . You are receiving this because you were mentioned.Message ID: @.***>