search

NCAR / noahmp

Noah-MP Community Repository
Other
72 stars 81 forks source link

Prevent stale values of calculate_soil from leaking across threads #136

Open lrbison opened 4 months ago

lrbison commented 4 months ago

Addresses issue #135.

lrbison commented 4 months ago

Another solution would be to move calculate_soil to be local to the noahmplsm subroutine, but that seems like it would have farther-reaching impact. Since all threads are on the same timestep, they should all end up with the same value of calculate_soil.

lrbison commented 1 month ago

ping on this PR, is the testing complete?

cenlinhe commented 1 month ago

ping on this PR, is the testing complete?

Sorry for the delay. Our team is overwhelmed by a number of things but this test is on top of our list and will be done soon.