search

NCAR / noahmp

Noah-MP Community Repository
Other
72 stars 81 forks source link

Fix nonstandard unary operator uses: *- #30

Closed davegill closed 2 years ago

davegill commented 2 years ago

These were found with testing for the NCAR derecho machine by Davide Del Vento for the WRF model. Any a * -b should be recast as a * (-b).

modified: module_sf_noahmplsm.F

davegill commented 2 years ago

@cenlinhe @davidedelvento @weiwangncar Cenlin, Now this is a 2-way feedback with NoahMP and WRF.

cenlinhe commented 2 years ago

@davegill Thanks. Looks good to me. By the way, what do you mean by "2-way feedback "?

davegill commented 2 years ago

@cenlinhe

By the way, what do you mean by "2-way feedback "?

NoahMP gives code the WRF, and WRF helps with bugfixes to NoahMP: a mutually beneficial, two-way interaction.

cenlinhe commented 2 years ago

@davegill you are right! This is an excellent demonstration!