search

NCAR / noahmp

Noah-MP Community Repository
Other
71 stars 81 forks source link

Croptype initialization #64

Closed cenlinhe closed 1 year ago

cenlinhe commented 1 year ago

https://github.com/NCAR/noahmp/blob/7ee673e88cc7a4351be329d92809a0c1ce027053/drivers/wrf/module_sf_noahmpdrv.F#L2199 @CharlesZheZhang Do you know why only the 5th crop type fraction (i.e., CROPTYPE(I,5,J)) is used in this if-statement here? I thought it should be the total fraction of all crop types instead of just the 5th crop type here.

CharlesZheZhang commented 1 year ago

Hi @cenlinhe, that's what this code is doing since there are four crop types so far. The CROPTYPE variable is structured in this way: 1st layer - corn fraction, 2nd layer - soybean fraction, 3rd layer - wheat fraction, 4th layer - cotton fraction, and 5th layer - total crop fraction.

cenlinhe commented 1 year ago

OK, I see. Now it makes sense to me. This CROPTYPE variable is generated by WPS, right? So it will automatically compute the total fraction and assign it to the 5th layer?

CharlesZheZhang commented 1 year ago

Yes, that's right, the CROPTYPE variable is generated by WPS.

cenlinhe commented 1 year ago

OK. But I thought there are 5 crop types, at least in MPTABLE, there are 5 columns for 5 crop types?

CharlesZheZhang commented 1 year ago

There are five columns in the MPTABLE, but only three columns are used: corn and soybean are from Xing's paper and wheat is under review. The other two columns are not used, though are assigned by name (sorghum and rice), their parameter values are copied from the previous column. That's why only corn and soybean fraction from the CROPTYPE variable are used to determine the dominant crop in the noahmp_init subroutine.

cenlinhe commented 1 year ago

OK, I see. Thanks! I am closing this issue based on the above discussions.